content/renderer/bluetooth/bluetooth_dispatcher.cc - Issue 1403723004: bluetooth: Implement BluetoothCharacteristicProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/bluetooth/bluetooth_dispatcher.cc

Issue 1403723004: bluetooth: Implement BluetoothCharacteristicProperties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-query-cache

Patch Set: Address scheib's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/bluetooth/bluetooth_dispatcher.h ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/bluetooth/bluetooth_dispatcher.cc

diff --git a/content/renderer/bluetooth/bluetooth_dispatcher.cc b/content/renderer/bluetooth/bluetooth_dispatcher.cc

index daa4e5dad5a0752434d1e53c435faf613bd54160..7a1c7d5ad4e82e56c5c79b2fb4caef3e56d03ccb 100644

--- a/content/renderer/bluetooth/bluetooth_dispatcher.cc

+++ b/content/renderer/bluetooth/bluetooth_dispatcher.cc

@@ -611,7 +611,8 @@ void BluetoothDispatcher::OnGetPrimaryServiceError(int thread_id,

void BluetoothDispatcher::OnGetCharacteristicSuccess(

int thread_id,

int request_id,

- const std::string& characteristic_instance_id) {

+ const std::string& characteristic_instance_id,

+ uint32 characteristic_properties) {

DCHECK(pending_characteristic_requests_.Lookup(request_id)) << request_id;

BluetoothCharacteristicRequest* request =

@@ -619,7 +620,8 @@ void BluetoothDispatcher::OnGetCharacteristicSuccess(

request->callbacks->onSuccess(

blink::adoptWebPtr(new WebBluetoothGATTCharacteristicInit(

WebString::fromUTF8(characteristic_instance_id),

- request->service_instance_id, request->characteristic_uuid)));

+ request->service_instance_id, request->characteristic_uuid,

+ characteristic_properties)));

pending_characteristic_requests_.Remove(request_id);

}