third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp - Issue 1403723004: bluetooth: Implement BluetoothCharacteristicProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

Issue 1403723004: bluetooth: Implement BluetoothCharacteristicProperties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-query-cache

Patch Set: Address scheib's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.h ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

index 16a629b7e33362b1c11a8f62d432a3c239f1c70f..0403ebef44343bb0e36112dbb0a0343e07fdc1a0 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

@@ -11,6 +11,7 @@

#include "core/dom/DOMException.h"

#include "core/dom/ExceptionCode.h"

#include "core/events/Event.h"

+#include "modules/bluetooth/BluetoothCharacteristicProperties.h"

#include "modules/bluetooth/BluetoothError.h"

#include "modules/bluetooth/BluetoothSupplement.h"

#include "modules/bluetooth/ConvertWebVectorToArrayBuffer.h"

@@ -23,6 +24,7 @@ BluetoothGATTCharacteristic::BluetoothGATTCharacteristic(ExecutionContext* conte

, m_webCharacteristic(webCharacteristic)

, m_stopped(false)

{

+ m_properties = BluetoothCharacteristicProperties::create(m_webCharacteristic->characteristicProperties);

// See example in Source/platform/heap/ThreadState.h

ThreadState::current()->registerPreFinalizer(this);

}

@@ -143,6 +145,7 @@ DEFINE_TRACE(BluetoothGATTCharacteristic)

{

RefCountedGarbageCollectedEventTargetWithInlineData<BluetoothGATTCharacteristic>::trace(visitor);

ActiveDOMObject::trace(visitor);

+ visitor->trace(m_properties);

}

} // namespace blink