Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1403263002: [Sharded Perf Tests] Disambiguate same benchmark on different steps (Closed)

Created:
5 years, 2 months ago by perezju
Modified:
5 years, 2 months ago
Reviewers:
eakuefner, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sharded Perf Tests] Disambiguate same benchmark on different steps Override the benchmark_name of a telemetry test if it is being run on a step (test_name) with a different name. BUG=541542 Committed: https://crrev.com/a4e76ad9ea2066e88eb04eb6290c2c883358c4a5 Cr-Commit-Position: refs/heads/master@{#354298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M build/android/pylib/perf/test_runner.py View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
perezju
5 years, 2 months ago (2015-10-15 14:15:45 UTC) #2
jbudorick
lgtm
5 years, 2 months ago (2015-10-15 14:19:17 UTC) #3
perezju
Ethan, let me know if this sounds reasonable to you, so I can go ahead ...
5 years, 2 months ago (2015-10-15 14:54:16 UTC) #4
eakuefner
On 2015/10/15 at 14:54:16, perezju wrote: > Ethan, let me know if this sounds reasonable ...
5 years, 2 months ago (2015-10-15 15:48:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403263002/1
5 years, 2 months ago (2015-10-15 16:14:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 17:48:13 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 17:49:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4e76ad9ea2066e88eb04eb6290c2c883358c4a5
Cr-Commit-Position: refs/heads/master@{#354298}

Powered by Google App Engine
This is Rietveld 408576698