Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: build/android/pylib/perf/test_runner.py

Issue 1403263002: [Sharded Perf Tests] Disambiguate same benchmark on different steps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/perf/test_runner.py
diff --git a/build/android/pylib/perf/test_runner.py b/build/android/pylib/perf/test_runner.py
index 26e17addab54b1a622b1381d8baa698f19ee823b..6beb117d86e114af9f31797018e880b8e45a7c24 100644
--- a/build/android/pylib/perf/test_runner.py
+++ b/build/android/pylib/perf/test_runner.py
@@ -392,6 +392,21 @@ class TestRunner(base_test_runner.BaseTestRunner):
test_name, exit_code, end_time - start_time,
self.device_serial)
+ try:
+ # Some perf configs run the same benchmark with different options on
+ # different step names. Here we disambiguate those, so that data is
+ # uploaded to the perf dashoards based on their step name instead.
+ chart_data = json.loads(json_output)
+ if chart_data['benchmark_name'] != test_name:
+ logging.info('Benchmark %r will be reported as %r in chartjson.',
+ chart_data['benchmark_name'], test_name)
+ chart_data['telemetry_benchmark_name'] = chart_data['benchmark_name']
+ chart_data['benchmark_name'] = test_name
+ json_output = json.dumps(chart_data, sort_keys=True, indent=2,
+ separators=(',', ': '))
+ except StandardError:
+ logging.exception('Could not read data from chartjson.')
+
if exit_code == 0:
result_type = base_test_result.ResultType.PASS
else:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698