Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1402913002: Debugger: fix stepping when break points are deactivated. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: fix stepping when break points are deactivated. The flag for deactivating break points also affects stepping, since both are implemented via debug break slots. Fixing this by introducing a new flag solely responsible for deactivating actual break points. R=mvstanton@chromium.org BUG=chromium:119800 LOG=N Committed: https://crrev.com/4f7caf2f57449b1499646739a22e274afe5aa7e8 Cr-Commit-Position: refs/heads/master@{#31236}

Patch Set 1 #

Patch Set 2 : fix test for stress test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M src/debug/debug.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/debug/debug.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/debug/debug.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-119800.js View 1 1 chunk +14 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 2 months ago (2015-10-13 07:49:54 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402913002/20001
5 years, 2 months ago (2015-10-13 08:04:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-13 08:27:01 UTC) #5
mvstanton
lgtm
5 years, 2 months ago (2015-10-13 12:42:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402913002/20001
5 years, 2 months ago (2015-10-13 12:42:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 12:44:13 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 12:44:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f7caf2f57449b1499646739a22e274afe5aa7e8
Cr-Commit-Position: refs/heads/master@{#31236}

Powered by Google App Engine
This is Rietveld 408576698