Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: test/mjsunit/regress/regress-crbug-119800.js

Issue 1402913002: Debugger: fix stepping when break points are deactivated. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test for stress test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-crbug-119800.js
diff --git a/test/mjsunit/debug-stepin-construct-call.js b/test/mjsunit/regress/regress-crbug-119800.js
similarity index 60%
copy from test/mjsunit/debug-stepin-construct-call.js
copy to test/mjsunit/regress/regress-crbug-119800.js
index 5e2145591fdb0bf6789fbc097ea7d5cb1ca5261e..1641cac686ef8c56699ff5140b805f6e9b1abf07 100644
--- a/test/mjsunit/debug-stepin-construct-call.js
+++ b/test/mjsunit/regress/regress-crbug-119800.js
@@ -4,39 +4,34 @@
// Flags: --expose-debug-as debug
-var break_count = 0;
+function f() {
+ 1;
+ 2;
+ 3;
+}
+
+var Debug = debug.Debug;
var exception = null;
+var breaks = [];
function listener(event, exec_state, event_data, data) {
if (event != Debug.DebugEvent.Break) return;
try {
- var source_line = exec_state.frame(0).sourceLineText();
- print(source_line);
+ Debug.debuggerFlags().breakPointsActive.setValue(false);
+ breaks.push(exec_state.frame().sourceLineText().trimLeft());
exec_state.prepareStep(Debug.StepAction.StepIn, 1);
- break_count++;
} catch (e) {
exception = e;
}
}
-var Debug = debug.Debug;
Debug.setListener(listener);
+Debug.setBreakPoint(f, 0, 0);
+f();
-function f() {
- this.x = 1;
-}
-
-function g() {
- new f();
-}
-
-Debug.setBreakPoint(g, 6, Debug.BreakPositionAlignment.BreakPosition);
-print(Debug.showBreakPoints(g, undefined,
- Debug.BreakPositionAlignment.BreakPosition));
-
-g();
Debug.setListener(null);
+Debug.debuggerFlags().breakPointsActive.setValue(true);
-assertEquals(6, break_count);
assertNull(exception);
+assertEquals(breaks, ["1;", "2;", "3;", "}", "Debug.setListener(null);"]);
« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698