Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1402913002: Debugger: fix stepping when break points are deactivated. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test for stress test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/mjsunit/regress/regress-crbug-119800.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 Smi::FromInt(thread->id().ToInteger())); 1058 Smi::FromInt(thread->id().ToInteger()));
1059 } 1059 }
1060 1060
1061 // Convert to JS array and return. 1061 // Convert to JS array and return.
1062 return *isolate->factory()->NewJSArrayWithElements(details); 1062 return *isolate->factory()->NewJSArrayWithElements(details);
1063 } 1063 }
1064 1064
1065 1065
1066 // Sets the disable break state 1066 // Sets the disable break state
1067 // args[0]: disable break state 1067 // args[0]: disable break state
1068 RUNTIME_FUNCTION(Runtime_SetDisableBreak) { 1068 RUNTIME_FUNCTION(Runtime_SetBreakPointsActive) {
1069 HandleScope scope(isolate); 1069 HandleScope scope(isolate);
1070 DCHECK(args.length() == 1); 1070 DCHECK(args.length() == 1);
1071 CONVERT_BOOLEAN_ARG_CHECKED(disable_break, 0); 1071 CONVERT_BOOLEAN_ARG_CHECKED(active, 0);
1072 isolate->debug()->set_disable_break(disable_break); 1072 isolate->debug()->set_break_points_active(active);
1073 return isolate->heap()->undefined_value(); 1073 return isolate->heap()->undefined_value();
1074 } 1074 }
1075 1075
1076 1076
1077 static bool IsPositionAlignmentCodeCorrect(int alignment) { 1077 static bool IsPositionAlignmentCodeCorrect(int alignment) {
1078 return alignment == STATEMENT_ALIGNED || alignment == BREAK_POSITION_ALIGNED; 1078 return alignment == STATEMENT_ALIGNED || alignment == BREAK_POSITION_ALIGNED;
1079 } 1079 }
1080 1080
1081 1081
1082 RUNTIME_FUNCTION(Runtime_GetBreakLocations) { 1082 RUNTIME_FUNCTION(Runtime_GetBreakLocations) {
(...skipping 631 matching lines...) Expand 10 before | Expand all | Expand 10 after
1714 return *isolate->factory()->undefined_value(); 1714 return *isolate->factory()->undefined_value();
1715 } 1715 }
1716 1716
1717 1717
1718 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1718 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1719 UNIMPLEMENTED(); 1719 UNIMPLEMENTED();
1720 return NULL; 1720 return NULL;
1721 } 1721 }
1722 } // namespace internal 1722 } // namespace internal
1723 } // namespace v8 1723 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/mjsunit/regress/regress-crbug-119800.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698