Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 14028011: Made AudioNode an EventTarget (Closed)

Created:
7 years, 8 months ago by russell.mcclellan
Modified:
7 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Made AudioNode an EventTarget According to the latest draft of the WebAudio Spec, AudioNode should be an EventTarget. BUG=230890 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150825

Patch Set 1 #

Total comments: 4

Patch Set 2 : Made AudioNode an EventTarget #

Patch Set 3 : Made AudioNode an EventTarget #

Total comments: 4

Patch Set 4 : Made AudioNode an EventTarget #

Total comments: 2

Patch Set 5 : Made AudioNode an EventTarget #

Patch Set 6 : #

Patch Set 7 : Made AudioNode an EventTarget #

Patch Set 8 : Made AudioNode an EventTarget #

Patch Set 9 : updated to latest #

Patch Set 10 : updating to latest #

Patch Set 11 : comma #

Patch Set 12 : #

Patch Set 13 : upate to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M LayoutTests/webaudio/audionode.html View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/webaudio/audionode-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.h View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +16 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.idl View 1 2 3 4 5 10 11 2 chunks +11 lines, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.h View 1 2 3 4 5 6 7 8 9 4 chunks +1 line, -18 lines 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -10 lines 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.idl View 1 2 10 11 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
russell.mcclellan
7 years, 8 months ago (2013-04-12 21:03:02 UTC) #1
haraken
LGTM in terms of implementation. Please wait for review from Chris. https://codereview.chromium.org/14028011/diff/1/LayoutTests/webaudio/audionode.html File LayoutTests/webaudio/audionode.html (right): ...
7 years, 8 months ago (2013-04-15 00:01:25 UTC) #2
Chris Rogers
Russell, thanks for continuing work on this. In the spirit of dividing patches up into ...
7 years, 8 months ago (2013-04-15 22:52:03 UTC) #3
russell.mcclellan
Understood. GC issues are indeed always a bit fiddly. I just removed the parts related ...
7 years, 8 months ago (2013-04-15 23:43:27 UTC) #4
Chris Rogers
Thanks Russell, this looks almost perfect. Please update the "Description" in this CL to not ...
7 years, 8 months ago (2013-04-16 21:03:03 UTC) #5
russell.mcclellan
https://codereview.chromium.org/14028011/diff/13001/Source/modules/webaudio/ScriptProcessorNode.h File Source/modules/webaudio/ScriptProcessorNode.h (left): https://codereview.chromium.org/14028011/diff/13001/Source/modules/webaudio/ScriptProcessorNode.h#oldcode79 Source/modules/webaudio/ScriptProcessorNode.h:79: using AudioNode::deref; On 2013/04/16 21:03:03, Chris Rogers wrote: > ...
7 years, 8 months ago (2013-04-17 01:59:45 UTC) #6
russell.mcclellan
On 2013/04/16 21:03:03, Chris Rogers wrote: > We can work on the ActiveDOMObject in another ...
7 years, 8 months ago (2013-04-17 02:09:14 UTC) #7
Chris Rogers
Kentaro, any ideas about [Optional] vs. optional?? otherwise looks good - please make sure trybots ...
7 years, 8 months ago (2013-04-17 21:38:20 UTC) #8
haraken
[Optional] was deprecated last week :) Use optional.
7 years, 8 months ago (2013-04-18 01:07:43 UTC) #9
Chris Rogers
thanks Kentaro, just waiting for "optional" then I can approve
7 years, 8 months ago (2013-04-18 23:03:15 UTC) #10
russell.mcclellan
I'm not really sure why the trybots are failing. It works locally for me on ...
7 years, 8 months ago (2013-04-24 01:50:57 UTC) #11
russell.mcclellan
Hey, looks like the only failures here aren't my fault. Anyone want to take a ...
7 years, 7 months ago (2013-05-21 14:29:41 UTC) #12
Chris Rogers
Russell, thanks! lgtm I can put this in the commit queue if you like
7 years, 7 months ago (2013-05-21 17:44:42 UTC) #13
russell.mcclellan
On 2013/05/21 17:44:42, Chris Rogers wrote: > I can put this in the commit queue ...
7 years, 7 months ago (2013-05-21 19:02:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/russell.mcclellan@gmail.com/14028011/74001
7 years, 7 months ago (2013-05-21 19:16:04 UTC) #15
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 20:45:43 UTC) #16
Message was sent while issue was closed.
Change committed as 150825

Powered by Google App Engine
This is Rietveld 408576698