Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: build/config/features.gni

Issue 1402783005: Remove safe_browsing=2 functionality, replace with =3 mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix up histograms Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains Chrome-feature-related build flags (see ui.gni for 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # UI-related ones). These should theoretically be moved to the build files of 6 # UI-related ones). These should theoretically be moved to the build files of
7 # the features themselves. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 enable_video_hole = is_android 92 enable_video_hole = is_android
93 93
94 # Enables browser side Content Decryption Modules. Required for embedders 94 # Enables browser side Content Decryption Modules. Required for embedders
95 # (e.g. Android and ChromeCast) that use a browser side CDM. 95 # (e.g. Android and ChromeCast) that use a browser side CDM.
96 enable_browser_cdms = is_android || is_chromecast 96 enable_browser_cdms = is_android || is_chromecast
97 97
98 # Hangout services is an extension that adds extra features to Hangouts. 98 # Hangout services is an extension that adds extra features to Hangouts.
99 # For official GYP builds, this flag is set. 99 # For official GYP builds, this flag is set.
100 enable_hangout_services_extension = false 100 enable_hangout_services_extension = false
101 101
102 # Variable safe_browsing is used to control the build time configuration 102 # Variable safe_browsing is used to control the build time configuration for
103 # for safe browsing feature. Safe browsing can be compiled in 4 different 103 # safe browsing feature. Safe browsing can be compiled in 3 different levels:
104 # levels: 0 disables it, 1 enables it fully, and 2 enables only UI and 104 # 0 disables it, 1 enables it fully, and 2 enables mobile protection via an
105 # reporting features for use with Data Saver on Mobile, and 3 enables 105 # external API.
106 # extended mobile protection via an external API.
107 if (is_android) { 106 if (is_android) {
108 safe_browsing_mode = 3 107 safe_browsing_mode = 2
109 } else if (is_ios) { 108 } else if (is_ios) {
110 safe_browsing_mode = 0 109 safe_browsing_mode = 0
111 } else { 110 } else {
112 safe_browsing_mode = 1 111 safe_browsing_mode = 1
113 } 112 }
114 113
115 # Set to true make a build that disables activation of field trial tests 114 # Set to true make a build that disables activation of field trial tests
116 # specified in testing/variations/fieldtrial_testing_config_*.json. 115 # specified in testing/variations/fieldtrial_testing_config_*.json.
117 # Note: this setting is ignored if is_chrome_branded. 116 # Note: this setting is ignored if is_chrome_branded.
118 fieldtrial_testing_like_official_build = is_chrome_branded 117 fieldtrial_testing_like_official_build = is_chrome_branded
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 # Option controlling the use of GConf (the classic GNOME configuration 197 # Option controlling the use of GConf (the classic GNOME configuration
199 # system). 198 # system).
200 use_gconf = is_linux && !is_chromeos && !is_chromecast 199 use_gconf = is_linux && !is_chromeos && !is_chromecast
201 200
202 # Whether to back up data before sync. 201 # Whether to back up data before sync.
203 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos) 202 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos)
204 203
205 # Enable WebVR support by default on Android 204 # Enable WebVR support by default on Android
206 # Still requires command line flag to access API 205 # Still requires command line flag to access API
207 enable_webvr = is_android 206 enable_webvr = is_android
OLDNEW
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698