Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Side by Side Diff: build/common.gypi

Issue 1402783005: Remove safe_browsing=2 functionality, replace with =3 mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix up histograms Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 # Set to select the Title Case versions of strings in GRD files. 409 # Set to select the Title Case versions of strings in GRD files.
410 'use_titlecase_in_grd%': 0, 410 'use_titlecase_in_grd%': 0,
411 411
412 # Remoting compilation is enabled by default. Set to 0 to disable. 412 # Remoting compilation is enabled by default. Set to 0 to disable.
413 'remoting%': 1, 413 'remoting%': 1,
414 414
415 # Configuration policy is enabled by default. Set to 0 to disable. 415 # Configuration policy is enabled by default. Set to 0 to disable.
416 'configuration_policy%': 1, 416 'configuration_policy%': 1,
417 417
418 # Variable safe_browsing is used to control the build time configuration 418 # Variable safe_browsing is used to control the build time configuration
419 # for safe browsing feature. Safe browsing can be compiled in 4 different 419 # for safe browsing feature. Safe browsing can be compiled in 3 different
420 # levels: 0 disables it, 1 enables it fully, and 2 enables only UI and 420 # levels: 0 disables it, 1 enables it fully, and 2 enables mobile
421 # reporting features for use with Data Saver on Mobile, and 3 enables 421 # protection via an external API.
422 # extended mobile protection via an external API. When 3 is fully
423 # deployed, it will replace 2.
424 'safe_browsing%': 1, 422 'safe_browsing%': 1,
425 423
426 # Web speech is enabled by default. Set to 0 to disable. 424 # Web speech is enabled by default. Set to 0 to disable.
427 'enable_web_speech%': 1, 425 'enable_web_speech%': 1,
428 426
429 # 'Ok Google' hotwording is disabled by default. Set to 1 to enable. (This 427 # 'Ok Google' hotwording is disabled by default. Set to 1 to enable. (This
430 # will download a closed-source NaCl module at startup.) Chrome-branded 428 # will download a closed-source NaCl module at startup.) Chrome-branded
431 # ChromeOS builds have this enabled by default. 429 # ChromeOS builds have this enabled by default.
432 'enable_hotwording%': 0, 430 'enable_hotwording%': 0,
433 431
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
1842 # breaking assumptions in the build system that when inputs have changed 1840 # breaking assumptions in the build system that when inputs have changed
1843 # the outputs should always change as well. This is meant purely for 1841 # the outputs should always change as well. This is meant purely for
1844 # developer builds, to avoid spurious re-linking of native files. 1842 # developer builds, to avoid spurious re-linking of native files.
1845 'optimize_jni_generation%': '<(optimize_jni_generation)', 1843 'optimize_jni_generation%': '<(optimize_jni_generation)',
1846 1844
1847 # Use OpenSSL's struct X509 to represent certificates. 1845 # Use OpenSSL's struct X509 to represent certificates.
1848 'use_openssl_certs%': 1, 1846 'use_openssl_certs%': 1,
1849 1847
1850 'proprietary_codecs%': '<(proprietary_codecs)', 1848 'proprietary_codecs%': '<(proprietary_codecs)',
1851 1849
1852 'safe_browsing%': 3, 1850 'safe_browsing%': 2,
1853 1851
1854 'enable_web_speech%': 0, 1852 'enable_web_speech%': 0,
1855 'java_bridge%': 1, 1853 'java_bridge%': 1,
1856 'use_allocator%': 'none', 1854 'use_allocator%': 'none',
1857 1855
1858 # Disable Native Client. 1856 # Disable Native Client.
1859 'disable_nacl%': 1, 1857 'disable_nacl%': 1,
1860 1858
1861 # Android does not support background apps. 1859 # Android does not support background apps.
1862 'enable_background%': 0, 1860 'enable_background%': 0,
(...skipping 1187 matching lines...) Expand 10 before | Expand all | Expand 10 after
3050 ['video_hole==1', { 3048 ['video_hole==1', {
3051 'defines': ['VIDEO_HOLE=1'], 3049 'defines': ['VIDEO_HOLE=1'],
3052 }], 3050 }],
3053 ['v8_use_external_startup_data==1', { 3051 ['v8_use_external_startup_data==1', {
3054 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'], 3052 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'],
3055 }], 3053 }],
3056 ['enable_webvr==1', { 3054 ['enable_webvr==1', {
3057 'defines': ['ENABLE_WEBVR'], 3055 'defines': ['ENABLE_WEBVR'],
3058 }], 3056 }],
3059 3057
3060 # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service.
3061 # SAFE_BROWSING_DB_LOCAL - service manages a local database. 3058 # SAFE_BROWSING_DB_LOCAL - service manages a local database.
3062 # SAFE_BROWSING_DB_REMOTE - service talks via API to a database 3059 # SAFE_BROWSING_DB_REMOTE - service talks via API to a database
3063 # SAFE_BROWSING_CSD - enable client-side phishing detection. 3060 # SAFE_BROWSING_CSD - enable client-side phishing detection.
3064 ['safe_browsing==1', { 3061 ['safe_browsing==1', {
3065 'defines': [ 3062 'defines': [
3066 # TODO(nparker): Remove existing uses of FULL_SAFE_BROWSING 3063 # TODO(nparker): Remove existing uses of FULL_SAFE_BROWSING
3067 'FULL_SAFE_BROWSING', 3064 'FULL_SAFE_BROWSING',
3068 'SAFE_BROWSING_CSD', 3065 'SAFE_BROWSING_CSD',
3069 'SAFE_BROWSING_DB_LOCAL', 3066 'SAFE_BROWSING_DB_LOCAL',
3070 'SAFE_BROWSING_SERVICE',
3071 ], 3067 ],
3072 }], 3068 }],
3073 ['safe_browsing==2', { 3069 ['safe_browsing==2', {
3074 'defines': [ 3070 'defines': [
3075 # TODO(nparker): Remove existing uses of MOBILE_SAFE_BROWSING
3076 'MOBILE_SAFE_BROWSING',
3077 'SAFE_BROWSING_SERVICE',
3078 ],
3079 }],
3080 ['safe_browsing==3', {
3081 'defines': [
3082 # TODO(nparker): Remove existing uses of MOBILE_SAFE_BROWSING
3083 'MOBILE_SAFE_BROWSING',
3084 'SAFE_BROWSING_DB_REMOTE', 3071 'SAFE_BROWSING_DB_REMOTE',
3085 'SAFE_BROWSING_SERVICE',
3086 ], 3072 ],
3087 }], 3073 }],
3088 ], # conditions for 'target_defaults' 3074 ], # conditions for 'target_defaults'
3089 'target_conditions': [ 3075 'target_conditions': [
3090 ['<(use_libpci)==1', { 3076 ['<(use_libpci)==1', {
3091 'defines': ['USE_LIBPCI=1'], 3077 'defines': ['USE_LIBPCI=1'],
3092 }], 3078 }],
3093 ['<(use_openssl)==1', { 3079 ['<(use_openssl)==1', {
3094 'defines': ['USE_OPENSSL=1'], 3080 'defines': ['USE_OPENSSL=1'],
3095 }], 3081 }],
(...skipping 3201 matching lines...) Expand 10 before | Expand all | Expand 10 after
6297 # settings in target dicts. SYMROOT is a special case, because many other 6283 # settings in target dicts. SYMROOT is a special case, because many other
6298 # Xcode variables depend on it, including variables such as 6284 # Xcode variables depend on it, including variables such as
6299 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6285 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6300 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6286 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6301 # files to appear (when present) in the UI as actual files and not red 6287 # files to appear (when present) in the UI as actual files and not red
6302 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6288 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6303 # and therefore SYMROOT, needs to be set at the project level. 6289 # and therefore SYMROOT, needs to be set at the project level.
6304 'SYMROOT': '<(DEPTH)/xcodebuild', 6290 'SYMROOT': '<(DEPTH)/xcodebuild',
6305 }, 6291 },
6306 } 6292 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698