Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402543002: Don't use base::MessageLoop::{Quit,QuitClosure} in ui/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tapted, sadrul, Matt Giuca, tdresser+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, kalyank, peter+watch_chromium.org, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in ui/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=sadrul@chromium.org Committed: https://crrev.com/fffec2a89279c42d223e9bb4d230401bfb7e31b3 Cr-Commit-Position: refs/heads/master@{#353581}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M ui/app_list/cocoa/test/apps_grid_controller_test_helper.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/app_list/pagination_model_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 1 chunk +1 line, -1 line 3 comments Download
M ui/events/platform/platform_event_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/animation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/test_animation_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/examples_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/nested_accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:09:10 UTC) #1
sadrul
lgtm https://codereview.chromium.org/1402543002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/1402543002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode413 ui/events/gesture_detection/gesture_provider_unittest.cc:413: base::MessageLoop::current()->Run(); This could be a non-static method that ...
5 years, 2 months ago (2015-10-09 20:48:25 UTC) #2
ki.stfu
https://codereview.chromium.org/1402543002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/1402543002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode413 ui/events/gesture_detection/gesture_provider_unittest.cc:413: base::MessageLoop::current()->Run(); Yes in theory, bug I'm not sure base::MessageLoop::current() ...
5 years, 2 months ago (2015-10-09 21:25:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402543002/1
5 years, 2 months ago (2015-10-10 06:47:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-10 06:51:43 UTC) #7
ki.stfu
https://codereview.chromium.org/1402543002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/1402543002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode413 ui/events/gesture_detection/gesture_provider_unittest.cc:413: base::MessageLoop::current()->Run(); On 2015/10/09 20:48:25, sadrul wrote: > This could ...
5 years, 2 months ago (2015-10-12 19:18:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402543002/1
5 years, 2 months ago (2015-10-12 19:20:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 20:08:32 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 20:09:51 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fffec2a89279c42d223e9bb4d230401bfb7e31b3
Cr-Commit-Position: refs/heads/master@{#353581}

Powered by Google App Engine
This is Rietveld 408576698