Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397443005: Remove unused message_loop_ field in GestureProviderTest (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused message_loop_ field in GestureProviderTest BUG= TEST= R=sadrul@chromium.org

Patch Set 1 #

Patch Set 2 : Add the inclusion back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/events/gesture_detection/gesture_provider_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ki.stfu
5 years, 2 months ago (2015-10-12 19:14:52 UTC) #1
sadrul
On 2015/10/12 19:14:52, ki.stfu wrote: As you can see from the test-failures, we actually do ...
5 years, 2 months ago (2015-10-13 21:26:43 UTC) #2
ki.stfu
On 2015/10/13 21:26:43, sadrul wrote: > On 2015/10/12 19:14:52, ki.stfu wrote: > > As you ...
5 years, 2 months ago (2015-10-14 04:23:36 UTC) #3
jdduke (slow)
On 2015/10/14 04:23:36, ki.stfu wrote: > On 2015/10/13 21:26:43, sadrul wrote: > > On 2015/10/12 ...
5 years, 2 months ago (2015-10-14 18:05:24 UTC) #4
ki.stfu
4 years, 7 months ago (2016-05-25 17:50:58 UTC) #5 
On 2015/10/14 18:05:24, jdduke (slow) wrote:
> On 2015/10/14 04:23:36, ki.stfu wrote:
> > On 2015/10/13 21:26:43, sadrul wrote:
> > > On 2015/10/12 19:14:52, ki.stfu wrote:
> > > 
> > > As you can see from the test-failures, we actually do need that.
> > 
> > Yes, I see but I didn't realise where and why it fails. Do you know?
> 
> We need a MessageLoop bound to the test thread to be able to post/pump tasks.
> While the object is not used explicitly, it is used implicitly, e.g. in the
> RunTasksAndWait() method and when the GestureDetector timer posts tasks.

OK, Thanks!

Powered by Google App Engine
This is Rietveld 408576698