Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3842)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h ('K') | « chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc ('k') | chrome/browser/ui/views/translate/translate_icon_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index 30694759de4f19816f97559803c91bc48541eed3..472cdbc9e40ce919900ba55f0fa48e9e55eb5dd8 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -119,10 +119,8 @@ void TranslateBubbleView::ShowBubble(
model.Pass(),
error_type,
web_contents);
- if (is_user_gesture)
- views::BubbleDelegateView::CreateBubble(view)->Show();
- else
- views::BubbleDelegateView::CreateBubble(view)->ShowInactive();
+ views::BubbleDelegateView::CreateBubble(view);
+ view->ShowForReason(is_user_gesture ? USER_ACTION : AUTOMATIC);
}
// static
« chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h ('K') | « chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc ('k') | chrome/browser/ui/views/translate/translate_icon_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698