Update location bar bubble/icon behavior.

chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
index 113520aa9a69046dbb8dd19210081d6fbc9cec96..62f72aff67fc22ef4f51ab9106a891f6856e8fa9 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
@@ -22,10 +22,15 @@ class WebContents;
 class LocationBarBubbleDelegateView : public views::BubbleDelegateView,
                                       public content::NotificationObserver {
  public:
+  enum DisplayReason { AUTOMATIC, USER_ACTION };

[Peter Kasting, 2015/11/10 00:24:18]

I'm not opposed to adding this, but it seems like if it's worth adding (versus
just using a bool), we should at least use it in every subclass of this (e.g.
SaveCardBubbleViews::Show()), if not everywhere in the CL.

This would also be useful in replacing some similar one-off ways we already
record this kind of thing, e.g. ManagePasswordsBubbleModel::AUTOMATIC, though I
haven't looked closely to ensure it's possible to refer to this everywhere
necessary.

Also, you might want to clarify here what these mean.  For example, if the
translate prompt is showing, and I click to "translate" the current page, and as
a result the "this page has been translated" bubble appears, is that a "user
action" or "automatic"?  "User action" could mean "icon clicked", or it could
mean "bubble shown during processing of some sort of user action somewhere in
the browser", or something in between.  (If it's the first, BTW, maybe
ICON_CLICKED would be a better enum value?)

[Evan Stade, 2015/11/10 19:18:26]

Done, but I left the enum value as USER_GESTURE to match all the various call
sites for bubbles.

+
   LocationBarBubbleDelegateView(views::View* anchor_view,
                                 content::WebContents* web_contents);
   ~LocationBarBubbleDelegateView() override;
 
+  // Displays the bubble as a result of |reason|.

[Peter Kasting, 2015/11/10 00:24:18]

You might want to note what we do differently in these cases.  For example, I
didn't realize that the bubble's active state (not just its appearance) differed
between the two.

[Evan Stade, 2015/11/10 19:18:26]

I don't like writing this type of comment because what's true today is not true
tomorrow, and there's no compiler for comments to make sure they stay correct.
The implementation is really short and easy to read, so that is the best
documentation. But I tried to improve this comment.

+  void ShowForReason(DisplayReason reason);
+
   // content::NotificationObserver:
   void Observe(int type,
                const content::NotificationSource& source,