Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402103004: Oilpan: Factor out GC-related enum definitions to BlinkGC.h (Closed)

Created:
5 years, 2 months ago by haraken
Modified:
5 years, 2 months ago
Reviewers:
keishi
CC:
chromium-reviews, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, yhirano+watch_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, Mads Ager (chromium), sof, darktears, Nate Chapin, tyoshino+watch_chromium.org, falken, oilpan-reviews, horo+watch_chromium.org, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Factor out GC-related enum definitions to BlinkGC.h ThreadState.h contains too many things. This CL factors out GC-related enums to BlinkGC.h. BlinkGC.h is going to be a place that defines common things in BlinkGC. BUG= Committed: https://crrev.com/e2b2e4b1f7f3f63d0f30ea3da8aa7a3182c60630 Cr-Commit-Position: refs/heads/master@{#354267}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -282 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CrossThreadTaskTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TaskSynchronizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 1 chunk +106 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 12 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 2 3 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 25 chunks +29 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PendingGCRunner.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 15 chunks +14 lines, -97 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 43 chunks +62 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/blink_heap.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebHeap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
haraken
PTAL
5 years, 2 months ago (2015-10-15 10:42:06 UTC) #2
keishi
On 2015/10/15 10:42:06, haraken wrote: > PTAL Missing BlinkGC.h?
5 years, 2 months ago (2015-10-15 10:45:35 UTC) #3
haraken
On 2015/10/15 10:45:35, keishi wrote: > On 2015/10/15 10:42:06, haraken wrote: > > PTAL > ...
5 years, 2 months ago (2015-10-15 10:47:23 UTC) #4
keishi
LGTM
5 years, 2 months ago (2015-10-15 11:35:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402103004/40001
5 years, 2 months ago (2015-10-15 11:41:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/133714)
5 years, 2 months ago (2015-10-15 12:18:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402103004/40001
5 years, 2 months ago (2015-10-15 12:56:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/133723)
5 years, 2 months ago (2015-10-15 13:30:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402103004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402103004/60001
5 years, 2 months ago (2015-10-15 13:46:01 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-15 15:05:43 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 15:06:39 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e2b2e4b1f7f3f63d0f30ea3da8aa7a3182c60630
Cr-Commit-Position: refs/heads/master@{#354267}

Powered by Google App Engine
This is Rietveld 408576698