third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp - Issue 1402103004: Oilpan: Factor out GC-related enum definitions to BlinkGC.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Issue 1402103004: Oilpan: Factor out GC-related enum definitions to BlinkGC.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp ('k') | third_party/WebKit/Source/platform/TaskSynchronizer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

index a4f8bcfddd152b53232944dc96ac7877f28e5596..8da31217c635a9d596e9f803ac586e9a3717f5fb 100644

--- a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

+++ b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

@@ -470,7 +470,7 @@ bool Bridge::waitForMethodCompletion(PassOwnPtr<ExecutionContextTask> task)

// We wait for the syncHelper event even if a shutdown event is fired.

// See https://codereview.chromium.org/267323004/#msg43 for why we need to wait this.

- SafePointScope scope(ThreadState::HeapPointersOnStack);

+ SafePointScope scope(BlinkGC::HeapPointersOnStack);

m_syncHelper->wait();

// This is checking whether a shutdown event is fired or not.

return !m_workerGlobalScope->thread()->terminated();