Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1401633003: Implement Material Design for the tabstrip. (Closed)

Created:
5 years, 2 months ago by Peter Kasting
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Material Design for the tabstrip. This is not quite final: * Hybrid mode is not implemented * Opaque frame positioning isn't yet correct * This temporarily causes background tab title text (for non-MD also) to use greyscale AA instead of LCD AA; there's a TODO to fix this However, it should work for the most part. sgabriel has OKed screenshots of this. BUG=519020 TEST=Running Chrome with --top-chrome-md=material results in a reasonable-looking tabstrip Committed: https://crrev.com/8cad69317a709849eccedcaf3822e3e55f993db5 Cr-Commit-Position: refs/heads/master@{#364209}

Patch Set 1 #

Patch Set 2 : Checkpoint #

Patch Set 3 : Resync #

Patch Set 4 : Fix 2x tab background #

Patch Set 5 : Color changes #

Total comments: 7

Patch Set 6 : Resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -268 lines) Patch
M chrome/browser/ui/layout_constants.cc View 1 2 3 4 5 2 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 2 3 4 5 3 chunks +74 lines, -41 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 4 5 chunks +102 lines, -58 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 4 5 8 chunks +203 lines, -70 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 3 4 5 10 chunks +243 lines, -84 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Peter Kasting
The diff isn't quite as large as it appears, as in many cases the existing ...
5 years ago (2015-12-09 01:20:30 UTC) #4
sky
Thanks for the comments, they helped make the review easier. LGTM
5 years ago (2015-12-09 17:08:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401633003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401633003/80001
5 years ago (2015-12-09 20:38:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/127208)
5 years ago (2015-12-09 21:40:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401633003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401633003/100001
5 years ago (2015-12-09 21:41:26 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-09 23:26:00 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-09 23:26:58 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8cad69317a709849eccedcaf3822e3e55f993db5
Cr-Commit-Position: refs/heads/master@{#364209}

Powered by Google App Engine
This is Rietveld 408576698