Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401273002: Move DDC to analyzer-based checker (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move DDC to analyzer-based checker this fully moves DDC over to analyzer for checking NOTE: there's one test failure in a .lib file, it may not be getting correctly analyzed. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5d8986a6127bc301c5d10c2a6e2c43e274d8d2d7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2742 lines) Patch
M lib/src/checker/checker.dart View 1 chunk +1 line, -942 lines 0 comments Download
M lib/src/checker/resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/checker/rules.dart View 1 chunk +1 line, -728 lines 0 comments Download
M lib/src/codegen/code_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M lib/src/compiler.dart View 1 5 chunks +26 lines, -29 lines 0 comments Download
M lib/src/info.dart View 2 chunks +3 lines, -475 lines 0 comments Download
M lib/src/server/server.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M lib/strong_mode.dart View 2 chunks +17 lines, -13 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/all_tests.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/codegen/expect/async_helper.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/async_helper/async_helper.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/cascade.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M test/codegen/expect/closure.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/collection/algorithms.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M test/codegen/expect/collection/equality.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
M test/codegen/expect/collection/iterable_zip.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/priority_queue.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
M test/codegen/expect/constructors.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/codegen/expect/expect.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/expect/expect/expect.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/expect/fieldtest.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/codegen/expect/js_test.txt View 1 1 chunk +0 lines, -361 lines 0 comments Download
M test/codegen/expect/methods.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/codegen/expect/misc.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/expect/opassign.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/syncstar_syntax.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/codegen/expect/unittest.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/codegen/expect/unittest/unittest.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/report_test.dart View 1 2 chunks +7 lines, -8 lines 0 comments Download
M test/testing.dart View 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
This is also available at https://github.com/dart-lang/dev_compiler/tree/checked_task This CL depends on https://codereview.chromium.org/1395853004
5 years, 2 months ago (2015-10-13 00:04:29 UTC) #2
Leaf
lgtm
5 years, 2 months ago (2015-10-13 18:31:10 UTC) #3
Jennifer Messerly
5 years, 2 months ago (2015-10-15 00:13:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5d8986a6127bc301c5d10c2a6e2c43e274d8d2d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698