Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: test/report_test.dart

Issue 1401273002: Move DDC to analyzer-based checker (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/unittest/unittest.txt ('k') | test/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/report_test.dart
diff --git a/test/report_test.dart b/test/report_test.dart
index 38d38222604af8ac335705b60eae996017834df3..6c929ec26f808137659356703dcd130b2e310e7e 100644
--- a/test/report_test.dart
+++ b/test/report_test.dart
@@ -24,13 +24,13 @@ void main() {
import 'package:foo/bar.dart';
test1() {
- x = /*severe:StaticTypeError*/"hi";
+ x = "hi";
}
'''.replaceAll('\n ', '\n'),
'package:foo/bar.dart': '''
- num x;
+ List x;
test2() {
- int y = /*info:AssignmentCast*/x;
+ List<String> y = x;
}
'''.replaceAll('\n ', '\n'),
};
@@ -55,16 +55,15 @@ void main() {
expect(mainMessage.kind, "StaticTypeError");
expect(mainMessage.level, "error");
expect(mainMessage.span.text, '"hi"');
- expect(
- mainMessage.span.context, ' x = /*severe:StaticTypeError*/"hi";\n');
+ expect(mainMessage.span.context, ' x = "hi";\n');
var barLib = summary.packages['foo'].libraries['package:foo/bar.dart'];
expect(barLib.messages.length, 1);
var barMessage = barLib.messages[0];
- expect(barMessage.kind, "AssignmentCast");
- expect(barMessage.level, "info");
+ expect(barMessage.kind, "DownCastComposite");
+ expect(barMessage.level, "warning");
expect(barMessage.span.text, 'x');
- expect(barMessage.span.context, ' int y = /*info:AssignmentCast*/x;\n');
+ expect(barMessage.span.context, ' List<String> y = x;\n');
}
var original = reporter.result;
« no previous file with comments | « test/codegen/expect/unittest/unittest.txt ('k') | test/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698