Issue 1395853004: FYI: add strong mode checking to error verifier's task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1395853004: FYI: add strong mode checking to error verifier's task (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly

Modified:
5 years ago

Reviewers:
Leaf

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

add strong mode checking to error verifier's task also changes the checker to use AnalysisErrorListener directly NOTE: this isn't the right long term task. This was mainly a way to see it working end to end.

Patch Set 1 #

Patch Set 2 : format #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -16 lines)			Patch
M	pkg/analyzer/lib/src/task/dart.dart	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/strong/checker.dart	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/task/strong/strong_test_helper.dart	View	1	5 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

5 years, 2 months ago (2015-10-13 00:05:56 UTC) #2

FYI. Not for submittal. @Leaf feel free to take this and run with it.

DDC side is: https://codereview.chromium.org/1401273002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages