third_party/WebKit/Source/core/frame/EventHandlerRegistry.h - Issue 1401033002: [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

Issue 1401033002: [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use WeakMember Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

diff --git a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

index b89ea927a4ad5d8ce3a45e8d2d4b52ba1ac6686d..dd75a91fb44c82a71e3b30b66c758556a4bf0e34 100644

--- a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

+++ b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

@@ -14,7 +14,7 @@ namespace blink {

class Document;

class EventTarget;

-typedef HashCountedSet<EventTarget*> EventTargetSet;

+using EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarget>>;

haraken 2015/10/13 07:10:45 Let's add a comment that the weak processing is ha

peria 2015/10/13 08:32:12 Done.

// Registry for keeping track of event handlers. Note that only handlers on

// documents that can be rendered or can receive input (i.e., are attached to a

« no previous file with comments | « no previous file | no next file » | no next file with comments »