Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1400813003: Revert of improve perf_basic_prof filename reporting (Closed)

Created:
5 years, 2 months ago by ofrobots
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of improve perf_basic_prof filename reporting (patchset #4 id:60001 of https://codereview.chromium.org/1396843004/ ) Reason for revert: The test-case has issues on windows. http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%203/builds/5011/steps/Check/logs/stdio Original issue's description: > improve perf_basic_prof filename reporting > > Re-implement https://codereview.chromium.org/1388543002 after fixing the issue > with SNPrintF crashing on windows when a zero-length buffer is passed in. > > R=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org > BUG=chromium:539892 > LOG=N > > Committed: https://crrev.com/701ba0b255f9c34f4b8c43584ef1e35040474e7d > Cr-Commit-Position: refs/heads/master@{#31197} TBR=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:539892 Committed: https://crrev.com/30b57dcd42ba7dd3632dd8882e74b4d5046ea84f Cr-Commit-Position: refs/heads/master@{#31198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -54 lines) Patch
M src/log.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ofrobots
Created Revert of improve perf_basic_prof filename reporting
5 years, 2 months ago (2015-10-09 17:41:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400813003/1
5 years, 2 months ago (2015-10-09 17:41:55 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-09 17:41:57 UTC) #4
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-09 18:27:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400813003/1
5 years, 2 months ago (2015-10-09 18:27:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 18:28:16 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 18:28:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30b57dcd42ba7dd3632dd8882e74b4d5046ea84f
Cr-Commit-Position: refs/heads/master@{#31198}

Powered by Google App Engine
This is Rietveld 408576698