Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1396843004: improve perf_basic_prof filename reporting (Closed)

Created:
5 years, 2 months ago by ofrobots
Modified:
5 years, 2 months ago
Reviewers:
Yang, yurys, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

improve perf_basic_prof filename reporting Re-implement https://codereview.chromium.org/1388543002 after fixing the issue with SNPrintF crashing on windows when a zero-length buffer is passed in. R=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org BUG=chromium:539892 LOG=N Committed: https://crrev.com/701ba0b255f9c34f4b8c43584ef1e35040474e7d Cr-Commit-Position: refs/heads/master@{#31197}

Patch Set 1 #

Patch Set 2 : fix asymmetry in AppendHex #

Patch Set 3 : dispose the isolate in the test #

Total comments: 2

Patch Set 4 : shorten url in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -5 lines) Patch
M src/log.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/test-log.cc View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ofrobots
5 years, 2 months ago (2015-10-08 22:00:39 UTC) #1
Jakob Kummerow
LGTM https://codereview.chromium.org/1396843004/diff/40001/test/cctest/test-log.cc File test/cctest/test-log.cc (right): https://codereview.chromium.org/1396843004/diff/40001/test/cctest/test-log.cc#newcode536 test/cctest/test-log.cc:536: // https://code.google.com/p/chromium/issues/detail?id=539892 nit: just "crbug.com/539892", it's cleaner.
5 years, 2 months ago (2015-10-09 09:51:34 UTC) #2
ofrobots
https://codereview.chromium.org/1396843004/diff/40001/test/cctest/test-log.cc File test/cctest/test-log.cc (right): https://codereview.chromium.org/1396843004/diff/40001/test/cctest/test-log.cc#newcode536 test/cctest/test-log.cc:536: // https://code.google.com/p/chromium/issues/detail?id=539892 On 2015/10/09 09:51:34, Jakob wrote: > nit: ...
5 years, 2 months ago (2015-10-09 16:53:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396843004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396843004/60001
5 years, 2 months ago (2015-10-09 16:54:21 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-09 17:17:28 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/701ba0b255f9c34f4b8c43584ef1e35040474e7d Cr-Commit-Position: refs/heads/master@{#31197}
5 years, 2 months ago (2015-10-09 17:17:51 UTC) #8
ofrobots
5 years, 2 months ago (2015-10-09 17:41:42 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1400813003/ by ofrobots@google.com.

The reason for reverting is: The test-case has issues on windows.
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%203....

Powered by Google App Engine
This is Rietveld 408576698