Remove ContextualSearchPanelDelegate

Remove ContextualSearchPanelDelegate

This delegate was largely used as a proxy for getters and setters
exposed by the ContextualSearchPanel. This adds an unnecessary layer
of complexity and required shell methods to expose base class
functions to the interface. Usages of this interface have been
replaced by either the ContextualSearchPanel or its base class,
OverlayPanel.

BUG=521773
Committed: https://crrev.com/815ca3f4b7cc8eea0233a7a15e6ac6f7a7eb9d33
Cr-Commit-Position: refs/heads/master@{#355316}

[mdjones, 2015-10-13 20:52:10]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org, pedrosimonetti@chromium.org

[mdjones, 2015-10-13 20:52:11]

There are arguably two methods that justify the existence of the delegate;
onSearchResultsLoaded() and onSearchTermResolutionResponse(...). I considered
leaving the delegate for these cases, however, they are both only used where the
panel is already available. Any thoughts or suggestions are welcome! PTAL

[pedro (no code reviews), 2015-10-15 06:13:11]

This change look good, but let's wait for the other change to land so I can take
a quick look before approving this CL.

[David Trainor- moved to gerrit, 2015-10-16 01:18:36]

lgtm but wait for pedro.

[pedro (no code reviews), 2015-10-20 01:33:52]

lgtm

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java
(right):

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:35:
public ContextualSearchBarControl(OverlayPanel panel, Context context, ViewGroup
container,
Nit: Put each argument on a separate line, to be consistent with the other
similar classes.

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
(right):

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:490:
*/
What is this commented code doing here? This method does not exist anymore.

[mdjones, 2015-10-20 15:25:03]

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java
(right):

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java:35:
public ContextualSearchBarControl(OverlayPanel panel, Context context, ViewGroup
container,
On 2015/10/20 01:33:52, pedrosimonetti wrote:
> Nit: Put each argument on a separate line, to be consistent with the other
> similar classes.

Done.

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
(right):

https://codereview.chromium.org/1399983004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:490:
*/
On 2015/10/20 01:33:52, pedrosimonetti wrote:
> What is this commented code doing here? This method does not exist anymore.

Forgot to remove this. Done

[mdjones, 2015-10-20 17:26:03]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-10-20 17:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1399983004/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2015-10-20 17:27:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399983004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399983004/40001

[pedro (no code reviews), 2015-10-20 17:48:14]

The CQ bit was unchecked by pedrosimonetti@chromium.org

[mdjones, 2015-10-21 16:36:25]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-10-21 16:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1399983004/#ps80001
(title: "fix rebase")

[commit-bot: I haz the power, 2015-10-21 16:36:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399983004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399983004/80001

[commit-bot: I haz the power, 2015-10-21 17:08:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-21 17:09:49]

Patchset 5 (id:??) landed as
https://crrev.com/815ca3f4b7cc8eea0233a7a15e6ac6f7a7eb9d33
Cr-Commit-Position: refs/heads/master@{#355316}