chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java - Issue 1399983004: Remove ContextualSearchPanelDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

Issue 1399983004: Remove ContextualSearchPanelDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract-contextual-search

Patch Set: fix rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

index dd456a46991485bb804e5139ba2a50c5827bb43c..ce31158ada7baf4e8c357816751b3e9913a38796 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java

@@ -7,7 +7,7 @@ package org.chromium.chrome.browser.contextualsearch;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.compositor.bottombar.OverlayContentDelegate;

import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;

-import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanelDelegate;

+import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content_public.common.TopControlsState;

@@ -53,10 +53,10 @@ public interface ContextualSearchManagementDelegate {

void promoteToTab();

/**

- * Sets the delegate responsible for manipulating the ContextualSearchLayout.

- * @param delegate The ContextualSearchLayoutDelegate.

+ * Sets the handle to the ContextualSearchPanel.

+ * @param delegate The ContextualSearchPanel.

- void setContextualSearchPanelDelegate(ContextualSearchPanelDelegate delegate);

+ void setContextualSearchPanel(ContextualSearchPanel panel);

/**

* Gets whether the device is running in compatibility mode for Contextual Search.