NPObject should not be retrieved as ScriptWrappable

NPObject should not be retrieved as ScriptWrappable

NPObject does not inherit from ScriptWrappable. Thus it is unsafe to retrieve
a NPObject* pointer from a wrapper as a ScriptWrappable* pointer.
This CL adds an ASSERT to check it.

BUG=

[haraken, 2015-10-15 11:10:50]

haraken@chromium.org changed reviewers:
+ vivekg@chromium.org, yukishiino@chromium.org

[haraken, 2015-10-15 11:10:50]

PTAL

[vivekg, 2015-10-15 11:23:22]

lgtm

https://codereview.chromium.org/1399763004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h (right):

https://codereview.chromium.org/1399763004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h:251: // NPObject is
not ScriptWrappable. We must not retrieve the pointer
nit: Shall we put a FIXME here to remove the code once we deprecate the usage of
NPObject?

[haraken, 2015-10-15 11:35:29]

https://codereview.chromium.org/1399763004/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h (right):
> 
>
https://codereview.chromium.org/1399763004/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h:251: // NPObject
is
> not ScriptWrappable. We must not retrieve the pointer
> nit: Shall we put a FIXME here to remove the code once we deprecate the usage
of
> NPObject?

Done.

[vivekg, 2015-10-15 13:05:27]

The CQ bit was checked by vivekg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 13:05:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399763004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399763004/20001

[commit-bot: I haz the power, 2015-10-15 13:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 13:36:10]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Yuki, 2015-10-15 13:37:57]

lgtm

[haraken, 2015-10-15 13:42:07]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-10-15 13:42:08]

The patchset sent to the CQ was uploaded after l-g-t-m from vivekg@chromium.org
Link to the patchset: https://codereview.chromium.org/1399763004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-10-15 13:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399763004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399763004/20001

[commit-bot: I haz the power, 2015-10-15 13:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 13:56:20]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2015-10-16 04:24:25]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:24:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399763004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399763004/20001

[commit-bot: I haz the power, 2015-10-16 04:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:49:09]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[rwlbuis, 2017-04-13 20:32:43]

rob.buis@samsung.com changed reviewers:
+ rob.buis@samsung.com

[rwlbuis, 2017-04-13 20:32:44]

@haraken I think this can be closed since support for NPObjects was removed?