third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp - Issue 1399763004: NPObject should not be retrieved as ScriptWrappable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp

Issue 1399763004: NPObject should not be retrieved as ScriptWrappable Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp b/third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp

index cc8ff429f2e55eb5a248503d2291b610ebaf06d8..97205ecc8594f0f297aad9205c8aceef01da0261 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8NPObject.cpp

@@ -482,7 +482,9 @@ v8::Local<v8::Object> createV8ObjectForNPObject(v8::Isolate* isolate, NPObject*

if (!V8ObjectConstructor::newInstance(isolate, v8Function).ToLocal(&value))

return v8::Local<v8::Object>();

- V8DOMWrapper::setNativeInfo(value, npObjectTypeInfo(), npObjectToScriptWrappable(object));

+ // NPObject is not ScriptWrappable. We must not retrieve the pointer as

+ // ScriptWrappable.

+ V8DOMWrapper::setNativeInfo(value, npObjectTypeInfo(), reinterpret_cast<ScriptWrappable*>(object));

// KJS retains the object as part of its wrapper (see Bindings::CInstance).

_NPN_RetainObject(object);