Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 13992003: Add support for parsing <grid-line> that includes a 'span' (Closed)

Created:
7 years, 8 months ago by Julien - ping for review
Modified:
7 years, 8 months ago
Reviewers:
tony, ojan
CC:
blink-reviews, apavlov+blink_chromium.org, Alexis Menard, jchaffraix+rendering
Visibility:
Public.

Description

Add support for parsing <grid-line> that includes a 'span' This adds the parsing, style resolution and getComputedStyle bits to our code. The rendering code was not made aware of the new type of GridPosition yet. BUG=229713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148766

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the change to match the specification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -10 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html View 1 6 chunks +106 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt View 1 4 chunks +54 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html View 4 chunks +42 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt View 2 chunks +16 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html View 4 chunks +42 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/css/CSSParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 2 chunks +45 lines, -1 line 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/StyleResolver.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StyleResolver.cpp View 1 3 chunks +37 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/style/GridPosition.h View 1 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Julien - ping for review
7 years, 8 months ago (2013-04-10 01:26:04 UTC) #1
ojan
https://codereview.chromium.org/13992003/diff/1/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html File LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html (right): https://codereview.chromium.org/13992003/diff/1/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html#newcode125 LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html:125: shouldBe("getComputedStyle(element, '').getPropertyValue('-webkit-grid-row')", "'span 20 / auto'"); This, and the ...
7 years, 8 months ago (2013-04-11 02:44:46 UTC) #2
Julien - ping for review
https://codereview.chromium.org/13992003/diff/1/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html File LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html (right): https://codereview.chromium.org/13992003/diff/1/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html#newcode125 LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html:125: shouldBe("getComputedStyle(element, '').getPropertyValue('-webkit-grid-row')", "'span 20 / auto'"); > Am I ...
7 years, 8 months ago (2013-04-17 14:26:26 UTC) #3
Julien - ping for review
Updated the change and the tests to match the specification. The main change is that ...
7 years, 8 months ago (2013-04-17 20:58:46 UTC) #4
ojan
lgtm
7 years, 8 months ago (2013-04-17 22:39:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/13992003/5001
7 years, 8 months ago (2013-04-19 21:31:58 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4567
7 years, 8 months ago (2013-04-19 22:05:43 UTC) #7
Julien - ping for review
7 years, 8 months ago (2013-04-19 23:18:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r148766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698