Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2280)

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 13992003: Add support for parsing <grid-line> that includes a 'span' (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed the change to match the specification Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/StyleResolver.cpp ('k') | Source/core/rendering/style/GridPosition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderGrid.cpp
diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp
index 8877297f4938f11dc3e6d175b3eaaf86cba1b3f9..e6e07d1eccfaa20f8940ea6403f94567c9032c85 100644
--- a/Source/core/rendering/RenderGrid.cpp
+++ b/Source/core/rendering/RenderGrid.cpp
@@ -795,6 +795,10 @@ size_t RenderGrid::resolveGridPositionFromStyle(const GridPosition& position, Gr
// 'auto' depends on the opposite position for resolution (e.g. grid-row: auto / 1).
ASSERT_NOT_REACHED();
return 0;
+ case SpanPosition:
+ // FIXME: Handle span positions (crbug.com/229713).
+ ASSERT_NOT_REACHED();
+ return 0;
}
ASSERT_NOT_REACHED();
return 0;
« no previous file with comments | « Source/core/css/StyleResolver.cpp ('k') | Source/core/rendering/style/GridPosition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698