Android gtest runner: Create only a single ApkHelper

Android gtest runner: Create only a single ApkHelper

Allow device_utils.Install() to be passed an ApkHelper rather than
always creating a new one.

Plumb the ApkHelper used by gtest_test_instance into the Install() call

Use this new ability in incremental_install/installer.py as well.

BUG=540857
Committed: https://crrev.com/7c7f080456d7388f0da5a78268d03ac5d8abe5b3
Cr-Commit-Position: refs/heads/master@{#353348}

[agrieve, 2015-10-09 14:34:50]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2015-10-09 14:34:57]

On 2015/10/09 14:34:50, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

♥

[jbudorick, 2015-10-09 16:19:53]

lgtm w/ nit

https://codereview.chromium.org/1398953002/diff/1/build/android/pylib/gtest/g...
File build/android/pylib/gtest/gtest_test_instance.py (right):

https://codereview.chromium.org/1398953002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:342: return self._apk_helper
and self._apk_helper.GetPackageName()
nit: I'd rather these return None than False if we don't have an APK.

[agrieve, 2015-10-09 17:16:04]

https://codereview.chromium.org/1398953002/diff/1/build/android/pylib/gtest/g...
File build/android/pylib/gtest/gtest_test_instance.py (right):

https://codereview.chromium.org/1398953002/diff/1/build/android/pylib/gtest/g...
build/android/pylib/gtest/gtest_test_instance.py:342: return self._apk_helper
and self._apk_helper.GetPackageName()
On 2015/10/09 16:19:53, jbudorick wrote:
> nit: I'd rather these return None than False if we don't have an APK.

They do return None.

[agrieve, 2015-10-09 17:16:13]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-10-09 17:17:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1398953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1398953002/1

[commit-bot: I haz the power, 2015-10-09 17:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 17:22:30]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[agrieve, 2015-10-09 17:56:52]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-10-09 17:56:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1398953002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-10-09 17:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1398953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1398953002/20001

[commit-bot: I haz the power, 2015-10-09 19:09:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-09 19:10:39]

Patchset 2 (id:??) landed as
https://crrev.com/7c7f080456d7388f0da5a78268d03ac5d8abe5b3
Cr-Commit-Position: refs/heads/master@{#353348}