Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4278)

Unified Diff: build/android/incremental_install/installer.py

Issue 1398953002: Android gtest runner: Create only a single ApkHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gtest-faster-10
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/devil/android/device_utils_test.py ('k') | build/android/pylib/gtest/gtest_test_instance.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/incremental_install/installer.py
diff --git a/build/android/incremental_install/installer.py b/build/android/incremental_install/installer.py
index b3f72ad7bea6952d40b232e8482703a171484780..40d2d7b6704b1984035aea75ee04061e83a48408 100755
--- a/build/android/incremental_install/installer.py
+++ b/build/android/incremental_install/installer.py
@@ -121,8 +121,8 @@ def main():
msg += ' %s (%s)\n' % (d, desc)
raise Exception(msg)
- apk_help = apk_helper.ApkHelper(args.apk_path)
- apk_package = apk_help.GetPackageName()
+ apk = apk_helper.ApkHelper(args.apk_path)
+ apk_package = apk.GetPackageName()
device_incremental_dir = '/data/local/tmp/incremental-app-%s' % apk_package
if args.uninstall:
@@ -139,10 +139,10 @@ def main():
splits = []
for split_glob in args.splits:
splits.extend((f for f in glob.glob(split_glob)))
- device.InstallSplitApk(args.apk_path, splits, reinstall=True,
+ device.InstallSplitApk(apk, splits, reinstall=True,
allow_cached_props=True, permissions=())
else:
- device.Install(args.apk_path, reinstall=True, permissions=())
+ device.Install(apk, reinstall=True, permissions=())
install_timer.Stop(log=False)
# Push .so and .dex files to the device (if they have changed).
@@ -173,7 +173,7 @@ def main():
# cases where this is required...
has_selinux = (device.build_version_sdk >= version_codes.MARSHMALLOW or
device.GetProp('selinux.policy_version'))
- if has_selinux and apk_help.HasIsolatedProcesses():
+ if has_selinux and apk.HasIsolatedProcesses():
raise Exception('Cannot use incremental installs on versions of Android '
'where isoloated processes cannot access the filesystem '
'(this includes Android M+, and Samsung L+) without '
« no previous file with comments | « build/android/devil/android/device_utils_test.py ('k') | build/android/pylib/gtest/gtest_test_instance.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698