build/android/pylib/local/device/local_device_gtest_run.py - Issue 1398953002: Android gtest runner: Create only a single ApkHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 1398953002: Android gtest runner: Create only a single ApkHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gtest-faster-10

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/local/device/local_device_gtest_run.py

diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py

index 0f360d4a9e943045c946f68689f98788fd2966e9..23604472ce638633e998bf60aa1f499634981dd0 100644

--- a/build/android/pylib/local/device/local_device_gtest_run.py

+++ b/build/android/pylib/local/device/local_device_gtest_run.py

@@ -55,7 +55,7 @@ def PullAppFilesImpl(device, package, files, directory):

class _ApkDelegate(object):

def __init__(self, test_instance):

self._activity = test_instance.activity

- self._apk = test_instance.apk

+ self._apk_helper = test_instance.apk_helper

self._package = test_instance.package

self._runner = test_instance.runner

self._permissions = test_instance.permissions

@@ -64,7 +64,7 @@ class _ApkDelegate(object):

self._extras = test_instance.extras

def Install(self, device):

- device.Install(self._apk, permissions=self._permissions)

+ device.Install(self._apk_helper, permissions=self._permissions)

def Run(self, test, device, flags=None, **kwargs):

extras = dict(self._extras)

« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance.py ('k') | no next file » | no next file with comments »