Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1398713002: Revert of CC Animations: Enable external animation host for blink. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, dzhioev+watch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CC Animations: Enable external animation host for blink. (patchset #6 id:100001 of https://codereview.chromium.org/1308053006/ ) Reason for revert: Breaks a number of tests across bots, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/55219 Confirmed locally that reverting addresses the instability. Original issue's description: > CC Animations: Enable external animation host for blink. > > Depends on blink layout tests: > https://codereview.chromium.org/1360233004/ > > BUG=394777 > > Committed: https://crrev.com/399f035cbbb4726b1a5fb3729d569dedaab7919e > Cr-Commit-Position: refs/heads/master@{#352989} TBR=ajuma@chromium.org,vollick@chromium.org,piman@chromium.org,loyso@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=394777 Committed: https://crrev.com/ef05b7da00844c0d500c4a7f20d4095dab56e7fe Cr-Commit-Position: refs/heads/master@{#353020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of CC Animations: Enable external animation host for blink.
5 years, 2 months ago (2015-10-08 08:21:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398713002/1
5 years, 2 months ago (2015-10-08 08:21:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 08:22:37 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 08:23:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef05b7da00844c0d500c4a7f20d4095dab56e7fe
Cr-Commit-Position: refs/heads/master@{#353020}

Powered by Google App Engine
This is Rietveld 408576698