build/android/devil/android/device_utils.py - Issue 1398613002: DeviceUtils.ForceStop: no-op if the app isn't running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils.py

Issue 1398613002: DeviceUtils.ForceStop: no-op if the app isn't running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_utils.py

diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py

index 73ed277c65d40aca9171ed28b7224e69d9292695..83a806fd7bfdd6e917d5698507c1dcfcac6637a8 100644

--- a/build/android/devil/android/device_utils.py

+++ b/build/android/devil/android/device_utils.py

@@ -1009,7 +1009,8 @@ class DeviceUtils(object):

CommandTimeoutError on timeout.

DeviceUnreachableError on missing device.

"""

- self.RunShellCommand(['am', 'force-stop', package], check_return=True)

+ cmd = 'p=%s;if [[ "$(ps)" = *$p* ]]; then am force-stop $p; fi'

+ self.RunShellCommand(cmd % package, check_return=True)

@decorators.WithTimeoutAndRetriesFromInstance()

def ClearApplicationState(

« no previous file with comments | « no previous file | build/android/devil/android/device_utils_test.py » ('j') | no next file with comments »