third_party/WebKit/Source/modules/vr/VRController.h - Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRController.h

Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp ('k') | third_party/WebKit/Source/modules/vr/VRHardwareUnit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRController.h

diff --git a/third_party/WebKit/Source/modules/vr/VRController.h b/third_party/WebKit/Source/modules/vr/VRController.h

index 83ca7a187a215110917a41a7fb1eb3ce16051335..fed11d5e663a17a4ee21dcf3b5cad64e7140cd1c 100644

--- a/third_party/WebKit/Source/modules/vr/VRController.h

+++ b/third_party/WebKit/Source/modules/vr/VRController.h

@@ -14,7 +14,7 @@

namespace blink {

class MODULES_EXPORT VRController final

- : public GarbageCollectedFinalized<VRController>

+ : public NoBaseWillBeGarbageCollectedFinalized<VRController>

, public WillBeHeapSupplement<LocalFrame>

, public LocalFrameLifecycleObserver {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(VRController);