third_party/WebKit/Source/modules/vr/VRHardwareUnit.h - Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRHardwareUnit.h

Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRController.h ('k') | third_party/WebKit/Source/modules/vr/VRHardwareUnit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRHardwareUnit.h

diff --git a/third_party/WebKit/Source/modules/vr/VRHardwareUnit.h b/third_party/WebKit/Source/modules/vr/VRHardwareUnit.h

index fc8bfeb9332628edd607b44805ced65601630a38..62a4cbeefca59402bf66aca9b288ba274be9bff6 100644

--- a/third_party/WebKit/Source/modules/vr/VRHardwareUnit.h

+++ b/third_party/WebKit/Source/modules/vr/VRHardwareUnit.h

@@ -26,7 +26,7 @@ enum VREye {

class VRHardwareUnit : public GarbageCollectedFinalized<VRHardwareUnit> {

public:

- explicit VRHardwareUnit(VRController*);

+ explicit VRHardwareUnit(NavigatorVRDevice*);

virtual ~VRHardwareUnit();

void updateFromWebVRDevice(const WebVRDevice&);

@@ -55,7 +55,7 @@ private:

unsigned m_frameIndex;

- Member<VRController> m_controller;

+ Member<NavigatorVRDevice> m_navigatorVRDevice;

Member<VRPositionState> m_positionState;

// Device types

« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRController.h ('k') | third_party/WebKit/Source/modules/vr/VRHardwareUnit.cpp » ('j') | no next file with comments »