third_party/WebKit/Source/modules/vr/VRController.h - Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/vr/VRController.h

Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef VRController_h	5 #ifndef VRController_h

6 #define VRController_h	6 #define VRController_h

7	7

8 #include "core/frame/LocalFrameLifecycleObserver.h"	8 #include "core/frame/LocalFrameLifecycleObserver.h"

9 #include "modules/ModulesExport.h"	9 #include "modules/ModulesExport.h"

10 #include "platform/Supplementable.h"	10 #include "platform/Supplementable.h"

11 #include "public/platform/modules/vr/WebVR.h"	11 #include "public/platform/modules/vr/WebVR.h"

12 #include "public/platform/modules/vr/WebVRClient.h"	12 #include "public/platform/modules/vr/WebVRClient.h"

13	13

14 namespace blink {	14 namespace blink {

15	15

16 class MODULES_EXPORT VRController final	16 class MODULES_EXPORT VRController final

17 : public GarbageCollectedFinalized<VRController>	17 : public NoBaseWillBeGarbageCollectedFinalized<VRController>

18 , public WillBeHeapSupplement<LocalFrame>	18 , public WillBeHeapSupplement<LocalFrame>

19 , public LocalFrameLifecycleObserver {	19 , public LocalFrameLifecycleObserver {

20 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(VRController);	20 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(VRController);

21 WTF_MAKE_NONCOPYABLE(VRController);	21 WTF_MAKE_NONCOPYABLE(VRController);

22 public:	22 public:

23 virtual ~VRController();	23 virtual ~VRController();

24	24

25 void getDevices(WebVRGetDevicesCallback*);	25 void getDevices(WebVRGetDevicesCallback*);

26	26

27 void getSensorState(unsigned index, WebHMDSensorState& into);	27 void getSensorState(unsigned index, WebHMDSensorState& into);

(...skipping 11 matching lines...) Expand all Loading...
39	39

40 // Inherited from LocalFrameLifecycleObserver.	40 // Inherited from LocalFrameLifecycleObserver.

41 void willDetachFrameHost() override;	41 void willDetachFrameHost() override;

42	42

43 WebVRClient* m_client;	43 WebVRClient* m_client;

44 };	44 };

45	45

46 } // namespace blink	46 } // namespace blink

47	47

48 #endif // VRController_h	48 #endif // VRController_h

OLD	NEW