Issue 13985039: Rationalize linux vs x11 in ui

Issue 13985039: Rationalize linux vs x11 in ui (Closed)

Created:
7 years, 8 months ago by DaveMoore

Modified:
7 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rationalize linux vs x11 in ui BUG=236170 TEST=None R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197087

Patch Set 2 : Remove unnecessary changes #

Patch Set 3 : Fix try failures #

Total comments: 1

Patch Set 4 : Fix review / try issues #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -879 lines)			Patch
M	build/build_config.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	gpu/gles2_conform_support/gles2_conform_support.gyp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	gpu/gles2_conform_support/native/egl_native_linux.cc	View	1 2	1 chunk	+0 lines, -123 lines	0 comments	Download
A +	gpu/gles2_conform_support/native/egl_native_x11.cc	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/base/resource/resource_bundle_auralinux.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/base/resource/resource_bundle_aurax11.cc	View		1 chunk	+0 lines, -54 lines	0 comments	Download
M	ui/gfx/pango_util.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/gl/gl.gyp	View	1 2 3	4 chunks	+5 lines, -5 lines	0 comments	Download
D	ui/gl/gl_context_linux.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download
A +	ui/gl/gl_context_x11.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/gl/gl_image_linux.cc	View		1 chunk	+0 lines, -52 lines	0 comments	Download
A +	ui/gl/gl_image_x11.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/gl/gl_implementation_linux.cc	View		1 chunk	+0 lines, -232 lines	0 comments	Download
A +	ui/gl/gl_implementation_x11.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/gl/gl_surface_linux.cc	View		1 chunk	+0 lines, -346 lines	0 comments	Download
A +	ui/gl/gl_surface_x11.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/surface/transport_dib.h	View	1 2	4 chunks	+8 lines, -4 lines	0 comments	Download
M	ui/surface/transport_dib_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ui.gyp	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm https://codereview.chromium.org/13985039/diff/9001/ui/gl/gl.gyp File ui/gl/gl.gyp (right): https://codereview.chromium.org/13985039/diff/9001/ui/gl/gl.gyp#newcode192 ui/gl/gl.gyp:192: # ['OS in ("win", "android") or (OS == ...

7 years, 7 months ago (2013-04-29 15:59:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #4 manually as r197087.

Expand Messages | Collapse Messages