Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397983007: relnote: remove insecure QUIC support (Closed)

Created:
5 years, 2 months ago by ramant (doing other things)
Modified:
5 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rch_insecure_quic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: remove insecure QUIC support Require a ProofSource in QuicCryptoServerConfig (this includes requiring SSL config for secure quic listeners) Require a ProofVerifier in QuicCryptoClientConfig. Remove is_https from QuicServerId. Remove is_secure from QuicServer. Merge internal change: 103869607 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -733 lines) Patch
M net/http/disk_cache_based_quic_server_info_unittest.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M net/quic/crypto/properties_based_quic_server_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 3 chunks +1 line, -8 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 9 chunks +14 lines, -28 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 16 chunks +28 lines, -37 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 3 chunks +2 lines, -8 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 11 chunks +13 lines, -31 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 6 chunks +13 lines, -5 lines 0 comments Download
M net/quic/p2p/quic_p2p_session_test.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 7 chunks +35 lines, -35 lines 0 comments Download
M net/quic/quic_connection.h View 3 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 5 chunks +5 lines, -14 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 3 chunks +9 lines, -17 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 3 chunks +4 lines, -33 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_server_id.h View 3 chunks +2 lines, -10 lines 0 comments Download
M net/quic/quic_server_id.cc View 4 chunks +11 lines, -24 lines 0 comments Download
M net/quic/quic_server_id_test.cc View 3 chunks +45 lines, -187 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 7 chunks +8 lines, -11 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 5 chunks +4 lines, -15 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +0 lines, -9 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client_base.h View 2 chunks +4 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M net/tools/quic/quic_client_test.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +2 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/tools/quic/quic_server.h View 2 chunks +3 lines, -8 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_bin.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M net/tools/quic/quic_simple_client_test.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 2 chunks +2 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_server.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_bin.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 4 chunks +1 line, -12 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 10 chunks +13 lines, -34 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 1393713003 Patch 80001

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
5 years, 2 months ago (2015-10-14 05:38:03 UTC) #1
ramant (doing other things)
Hi Ryan, This CL requires landing of https://codereview.chromium.org/1393713003/. This change helps to test all crypto ...
5 years, 2 months ago (2015-10-14 05:41:28 UTC) #2
Ryan Hamilton
5 years, 2 months ago (2015-10-14 13:37:24 UTC) #3 
LGTM! The ChromiumClientSession test changes look good, too.

Powered by Google App Engine
This is Rietveld 408576698