Remove insecure QUIC support from Chromium.

Remove insecure QUIC support from Chromium.

Committed: https://crrev.com/f114d9850b9775da090398bce6d5752ccda4b844
Cr-Commit-Position: refs/heads/master@{#355214}

[Ryan Hamilton, 2015-10-07 03:56:13]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-10-07 16:57:06]

lgtm

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_end_to_en...
File net/quic/quic_end_to_end_unittest.cc (right):

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_end_to_en...
net/quic/quic_end_to_end_unittest.cc:107:
cert_verifier_.AddResultForCertAndHost(verify_result.verified_cert.get(),
nit: lines 104-106 and 107-109 are the same.

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_network_t...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_network_t...
net/quic/quic_network_transaction_unittest.cc:653: //
MockRead(kQuicAlternateProtocolHeader), MockRead("hello world"),
nit: consider deleting line#653

[Ryan Hamilton, 2015-10-07 22:13:26]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-07 22:13:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1393713003/#ps40001
(title: "fix comments")

[Ryan Hamilton, 2015-10-07 22:14:14]

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_end_to_en...
File net/quic/quic_end_to_end_unittest.cc (right):

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_end_to_en...
net/quic/quic_end_to_end_unittest.cc:107:
cert_verifier_.AddResultForCertAndHost(verify_result.verified_cert.get(),
On 2015/10/07 16:57:05, ramant wrote:
> nit: lines 104-106 and 107-109 are the same.

Done.

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_network_t...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1393713003/diff/20001/net/quic/quic_network_t...
net/quic/quic_network_transaction_unittest.cc:653: //
MockRead(kQuicAlternateProtocolHeader), MockRead("hello world"),
On 2015/10/07 16:57:06, ramant wrote:
> nit: consider deleting line#653

Done.

[commit-bot: I haz the power, 2015-10-07 22:14:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393713003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393713003/40001

[commit-bot: I haz the power, 2015-10-07 22:32:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-07 22:32:59]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Ryan Hamilton, 2015-10-07 23:27:30]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-07 23:27:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1393713003/#ps60001
(title: "rebase and fix clients")

[commit-bot: I haz the power, 2015-10-07 23:29:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393713003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393713003/60001

[commit-bot: I haz the power, 2015-10-07 23:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-07 23:46:24]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[Ryan Hamilton, 2015-10-08 02:36:39]

rch@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Ryan Hamilton, 2015-10-08 02:36:39]

xunjieli: can your review components/

[xunjieli, 2015-10-08 13:53:35]

On 2015/10/08 02:36:39, Ryan Hamilton wrote:
> xunjieli: can your review components/

This will break Cronet tests, since Cronet's version of quic simple server does
not have a cert (components/cronet/android/test/quic_test_server.cc). I will do
it. But I need a day or two.

[Ryan Hamilton, 2015-10-08 14:11:15]

On 2015/10/08 13:53:35, xunjieli wrote:
> On 2015/10/08 02:36:39, Ryan Hamilton wrote:
> > xunjieli: can your review components/
> 
> This will break Cronet tests, since Cronet's version of quic simple server
does
> not have a cert (components/cronet/android/test/quic_test_server.cc). I will
do
> it. But I need a day or two.

Thanks. It's unfortunate that these tests are not part of the chromium tree
because it means that I can land code which breaks the tests even though all the
bots are green. :/

[xunjieli, 2015-10-08 14:22:24]

On 2015/10/08 14:11:15, Ryan Hamilton wrote:
> On 2015/10/08 13:53:35, xunjieli wrote:
> > On 2015/10/08 02:36:39, Ryan Hamilton wrote:
> > > xunjieli: can your review components/
> > 
> > This will break Cronet tests, since Cronet's version of quic simple server
> does
> > not have a cert (components/cronet/android/test/quic_test_server.cc). I will
> do
> > it. But I need a day or two.
> 
> Thanks. It's unfortunate that these tests are not part of the chromium tree
> because it means that I can land code which breaks the tests even though all
the
> bots are green. :/

Yes. That's unfortunate. Our tests run for a long time, so can't be a part of
CQ. But Cronet try bot is coming online soon (I hope), so it'll be easier in the
future. I will work on the tests now. CC-ing pauljensen who was working on a
related Cronet perf test.

[xunjieli, 2015-10-20 16:44:16]

Hey Ryan, I think I have the l-g-t-ms. Do you want to patch my CL
(https://codereview.chromium.org/1389213003/) with this one or have me land it
shortly after you land yours?

[Ryan Hamilton, 2015-10-20 19:45:19]

On 2015/10/20 16:44:16, xunjieli wrote:
> Hey Ryan, I think I have the l-g-t-ms. Do you want to patch my CL
> (https://codereview.chromium.org/1389213003/) with this one or have me land it
> shortly after you land yours?

Woo hoo! I think you can land your CL and once it's in, I can land this.

[xunjieli, 2015-10-20 19:46:13]

On 2015/10/20 19:45:19, Ryan Hamilton wrote:
> On 2015/10/20 16:44:16, xunjieli wrote:
> > Hey Ryan, I think I have the l-g-t-ms. Do you want to patch my CL
> > (https://codereview.chromium.org/1389213003/) with this one or have me land
it
> > shortly after you land yours?
> 
> Woo hoo! I think you can land your CL and once it's in, I can land this.

Sounds good! lgtm.

[Ryan Hamilton, 2015-10-20 23:27:19]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-20 23:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1393713003/#ps80001
(title: "fix components")

[commit-bot: I haz the power, 2015-10-20 23:28:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393713003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393713003/80001

[commit-bot: I haz the power, 2015-10-20 23:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 23:30:59]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2015-10-21 00:24:41]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-10-21 00:24:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org, xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1393713003/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-21 00:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393713003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393713003/100001

[commit-bot: I haz the power, 2015-10-21 01:35:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-21 01:36:01]

Patchset 6 (id:??) landed as
https://crrev.com/f114d9850b9775da090398bce6d5752ccda4b844
Cr-Commit-Position: refs/heads/master@{#355214}