Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 13976008: Remove more #includes from Frame.h (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, aboxhall, pfeldman+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, feature-media-reviews_chromium.org, dmazzoni, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, pdr, f(malita), Stephen Chennney, aandrey+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove more #includes from Frame.h Merges http://trac.webkit.org/changeset/148545 from Sam Weinig. The idea is again that this improves compile time, as Frame.h is a frequently included header. BUG=none TBR=eseidel (who said "this change sgtm" on the review) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148612

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -26 lines) Patch
M Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/PageWidgetDelegate.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPagePopupImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginContainerImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebRange.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/mac/WebSubstringUtil.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/accessibility/AccessibilityObject.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/AlternativeTextController.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/SpellingCorrectionCommand.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/history/CachedFrame.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/ClearButtonElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/Frame.h View 1 2 4 chunks +23 lines, -13 lines 0 comments Download
M Source/core/page/Frame.cpp View 1 2 4 chunks +9 lines, -5 lines 0 comments Download
M Source/core/page/FrameView.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/FrameView.cpp View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/chromium/ClipboardChromium.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/chromium/PasteboardChromium.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
r? More of https://codereview.chromium.org/14323004/ I like to write one more CL like this, then I'll ...
7 years, 8 months ago (2013-04-17 05:30:05 UTC) #1
Nico
(and I won't land any before I have numbers)
7 years, 8 months ago (2013-04-17 05:30:17 UTC) #2
eseidel
When I last tried to do this in the https://bugs.webkit.org/show_bug.cgi?id=3761 bug tree, I remember facing ...
7 years, 8 months ago (2013-04-17 06:17:38 UTC) #3
eseidel
I'm excited to hear your compile perf numbers. This changes sgtm. https://codereview.chromium.org/13976008/diff/2001/Source/WebCore/page/Frame.h File Source/WebCore/page/Frame.h (right): ...
7 years, 8 months ago (2013-04-17 06:18:46 UTC) #4
Nico
Can i get a formal "lgtm" please?
7 years, 8 months ago (2013-04-17 20:01:56 UTC) #5
Nico
(…and the promised perf numbers are at https://codereview.chromium.org/13926016/)
7 years, 8 months ago (2013-04-18 04:04:10 UTC) #6
Nico
Committed patchset #3 manually as r148612 (presubmit successful).
7 years, 8 months ago (2013-04-18 04:07:49 UTC) #7
eseidel
7 years, 8 months ago (2013-04-18 05:10:56 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698