Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 13975019: Merge 194269 (Closed)

Created:
7 years, 8 months ago by ddrew
Modified:
7 years, 8 months ago
Reviewers:
reveman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Merge 194269 > cc: Add strict layer property change checking and handle bounds changes during paint. > > This fixes a problem where paint would cause layer bounds to change > and Layer::PushProperties to push an non-empty picture layer without > a recording to the impl side. > > This also adds a new command line switch that make layer property > changes during paint cause a CHECK() to fail. This can be used > to diagnose situations where paint is incorrectly causing layer > properties to change. > > BUG=229179 > TEST=cc_unittests --gtest_filter=LayerTreeHostTestChangeLayerPropertiesInPaintContents.RunSingleThread > > Review URL: https://codereview.chromium.org/13939005 TBR=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -12 lines) Patch
M cc/base/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/contents_scaling_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 5 chunks +9 lines, -0 lines 0 comments Download
M cc/layers/layer.cc View 34 chunks +54 lines, -5 lines 0 comments Download
A + cc/layers/paint_properties.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M cc/layers/tiled_layer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 31 chunks +36 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 3 chunks +6 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ddrew
7 years, 8 months ago (2013-04-16 06:34:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698