Retrying the setUp/tearDown chaining change. This is the same as r21819 but with a change to schedu…

pkg/scheduled_test/lib/scheduled_test.dart

Index: pkg/scheduled_test/lib/scheduled_test.dart
===================================================================
--- pkg/scheduled_test/lib/scheduled_test.dart	(revision 21853)
+++ pkg/scheduled_test/lib/scheduled_test.dart	(working copy)
@@ -314,11 +314,9 @@
   if (!_inGroup) _setUpForTopLevel = true;
 
   unittest.setUp(() {
-    if (currentSchedule != null) {
-      throw new StateError('There seems to be another scheduled test '
-          'still running.');

[nweiz, 2013/04/23 00:04:53]

Why is this being removed? This is important, since async tests can potentially
keep running when you don't expect them to.

[gram, 2013/04/23 00:07:05]

Because it is completely broken with the chaining of setup calls. You are pretty
much guaranteed to throw if you have groups, because you will have generated a
top level setup that gets called and sets currentSchedule to non-null, and then
a nested setup that gets called and throws.

[nweiz, 2013/04/23 00:20:52]

We should fix that, then, rather than just removing the functionality. We're
already tracking whether we're in a group or not.

[gram, 2013/04/23 19:42:47]

Done.

+    if (currentSchedule == null) {
+      _currentSchedule = new Schedule();
     }
-    _currentSchedule = new Schedule();
     _setUpFn = setUpFn;
   });