Retrying the setUp/tearDown chaining change. This is the same as r21819 but with a change to schedu…

pkg/scheduled_test/lib/scheduled_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(nweiz): Add support for calling [schedule] while the schedule is already
 // running.
 // TODO(nweiz): Port the non-Pub-specific scheduled test libraries from Pub.
 /// A package for writing readable tests of asynchronous behavior.
 ///
 /// ## Installing ##
@@ skipping 296 matching lines @@
   if (_inGroup || _setUpForTopLevel) return;
   _setUpScheduledTest();
 }
 
 /// Registers callbacks for [unittest.setUp] and [unittest.tearDown] that set up
 /// and tear down the scheduled test infrastructure.
 void _setUpScheduledTest([void setUpFn()]) {
   if (!_inGroup) _setUpForTopLevel = true;
 
   unittest.setUp(() {
-    if (currentSchedule != null) {
-      throw new StateError('There seems to be another scheduled test '
-          'still running.');

[nweiz, 2013/04/23 00:04:53]

Why is this being removed? This is important, since async tests can potentially
keep running when you don't expect them to.

[gram, 2013/04/23 00:07:05]

Because it is completely broken with the chaining of setup calls. You are pretty
much guaranteed to throw if you have groups, because you will have generated a
top level setup that gets called and sets currentSchedule to non-null, and then
a nested setup that gets called and throws.

[nweiz, 2013/04/23 00:20:52]

We should fix that, then, rather than just removing the functionality. We're
already tracking whether we're in a group or not.

[gram, 2013/04/23 19:42:47]

Done.

+    if (currentSchedule == null) {
+      _currentSchedule = new Schedule();
     }
-    _currentSchedule = new Schedule();
     _setUpFn = setUpFn;
   });
 
   unittest.tearDown(() {
     _currentSchedule = null;
   });
 }
 
 /// Ensures that the global configuration for `scheduled_test` has been
 /// initialized.
@@ skipping 26 matching lines @@
 
   return currentSchedule.wrapFuture(future, description);
 }
 
 // TODO(nweiz): re-export these once issue 9535 is fixed.
 unittest.Configuration get unittestConfiguration =>
   unittest.unittestConfiguration;
 void set unittestConfiguration(unittest.Configuration value) {
   unittest.unittestConfiguration = value;
 }