Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: pkg/scheduled_test/test/scheduled_test/set_up_test.dart

Issue 13973021: Retrying the setUp/tearDown chaining change. This is the same as r21819 but with a change to schedu… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/test/scheduled_test/set_up_test.dart
===================================================================
--- pkg/scheduled_test/test/scheduled_test/set_up_test.dart (revision 21853)
+++ pkg/scheduled_test/test/scheduled_test/set_up_test.dart (working copy)
@@ -79,46 +79,6 @@
test('test 2', () => expect(onExceptionRun, isTrue));
}, passing: ['test 2']);
- expectTestsPass("setUp doesn't apply to child groups", () {
- var setUpRun = false;
- setUp(() {
- setUpRun = true;
- currentSchedule.onComplete.schedule(() {
- setUpRun = false;
- });
- });
-
- test('outer', () {
- expect(setUpRun, isTrue);
- });
-
- group('group', () {
- test('inner', () {
- expect(setUpRun, isFalse);
- });
- });
- });
-
- expectTestsPass("setUp doesn't apply to parent groups", () {
- var setUpRun = false;
- group('group', () {
- setUp(() {
- setUpRun = true;
- currentSchedule.onComplete.schedule(() {
- setUpRun = false;
- });
- });
-
- test('inner', () {
- expect(setUpRun, isTrue);
- });
- });
-
- test('outer', () {
- expect(setUpRun, isFalse);
- });
- });
nweiz 2013/04/23 00:20:52 These should be replaced by tests that setUp *does
gram 2013/04/23 19:42:47 Done.
-
expectTestsPass("setUp doesn't apply to sibling groups", () {
var setUpRun = false;
group('group 1', () {
@@ -140,4 +100,4 @@
});
});
});
-}
+}

Powered by Google App Engine
This is Rietveld 408576698