Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: Source/WebKit/chromium/public/WebInbandTextTrack.h

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporate aaron's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/public/WebInbandTextTrack.h
diff --git a/Source/WebKit/chromium/public/WebValidationMessageClient.h b/Source/WebKit/chromium/public/WebInbandTextTrack.h
similarity index 68%
copy from Source/WebKit/chromium/public/WebValidationMessageClient.h
copy to Source/WebKit/chromium/public/WebInbandTextTrack.h
index 6ba1555272942b015102b4c3df0b3d2ba2e8867c..593857ca163bb4eb9527d791f52337f932a79a58 100644
--- a/Source/WebKit/chromium/public/WebValidationMessageClient.h
+++ b/Source/WebKit/chromium/public/WebInbandTextTrack.h
@@ -28,30 +28,35 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebValidationMessageClient_h
-#define WebValidationMessageClient_h
-
-#include "WebTextDirection.h"
+#ifndef WebInbandTextTrack_h
+#define WebInbandTextTrack_h
namespace WebKit {
class WebString;
-struct WebRect;
+class WebInbandTextTrackClient;
+
+class WebInbandTextTrack {
+ public:
abarth-chromium 2013/04/30 18:36:16 Please use Blink style (e.g., four-space indent)
Matthew Heaney (Chromium) 2013/05/01 04:38:24 Done.
+ enum Kind { KindSubtitles, KindCaptions, KindDescriptions, KindChapters, KindMetadata, KindNone };
+ enum Mode { ModeDisabled, ModeHidden, ModeShowing };
abarth-chromium 2013/04/30 18:36:16 Please put the enum values on separate lines so th
Matthew Heaney (Chromium) 2013/05/01 04:38:24 Done.
+
+ virtual ~WebInbandTextTrack() {}
+
+ virtual void setClient(WebInbandTextTrackClient*) = 0;
+ virtual WebInbandTextTrackClient* client() = 0;
-// Client interface to handle form validation message UI.
-class WebValidationMessageClient {
-public:
- // Show a notification popup for the specified form vaidation messages
- // besides the anchor rectangle. An implementation of this function should
- // not hide the popup until hideValidationMessage call.
- virtual void showValidationMessage(const WebRect& anchorInScreen, const WebString& mainText, const WebString& supplementalText, WebTextDirection hint) { }
+ virtual void setMode(Mode) = 0;
+ virtual Mode mode() const = 0;
- // Hide notifation popup for form validation messages.
- virtual void hideValidationMessage() { }
+ virtual Kind kind() const = 0;
+ virtual bool isClosedCaptions() const = 0;
+ virtual WebString label() const = 0;
+ virtual WebString language() const = 0;
+ virtual bool isDefault() const = 0;
-protected:
- virtual ~WebValidationMessageClient() { }
+ virtual int textTrackIndex() const = 0;
abarth-chromium 2013/04/30 18:36:16 Should the index be size_t ?
Matthew Heaney (Chromium) 2013/05/01 04:38:24 Good question. Should we also rename this method,
};
} // namespace WebKit

Powered by Google App Engine
This is Rietveld 408576698