Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: Source/WebKit/chromium/public/WebInbandTextTrackClient.h

Issue 13968007: Create WebInbandTextTrack and WebInbandTextTrackClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporate aaron's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/public/WebInbandTextTrackClient.h
diff --git a/Source/WebKit/chromium/public/WebSourceBuffer.h b/Source/WebKit/chromium/public/WebInbandTextTrackClient.h
similarity index 79%
copy from Source/WebKit/chromium/public/WebSourceBuffer.h
copy to Source/WebKit/chromium/public/WebInbandTextTrackClient.h
index 064626cda9b94ff4f61c35b10b2bb8d73f8af9d9..9f2777066ada750f827b22a16bd9243c86ebf9e9 100644
--- a/Source/WebKit/chromium/public/WebSourceBuffer.h
+++ b/Source/WebKit/chromium/public/WebInbandTextTrackClient.h
@@ -28,22 +28,22 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebSourceBuffer_h
-#define WebSourceBuffer_h
-
-#include "WebTimeRange.h"
+#ifndef WebInbandTextTrackClient_h
+#define WebInbandTextTrackClient_h
namespace WebKit {
-class WebSourceBuffer {
-public:
- virtual ~WebSourceBuffer() { }
+class WebString;
+
+class WebInbandTextTrackClient {
+ public:
+ virtual ~WebInbandTextTrackClient() {}
abarth-chromium 2013/04/30 18:36:16 Please use Blinks style (e.g., four-space indent)
Matthew Heaney (Chromium) 2013/05/01 04:38:24 Done.
- virtual WebTimeRanges buffered() = 0;
- virtual void append(const unsigned char* data, unsigned length) = 0;
- virtual void abort() = 0;
- virtual bool setTimestampOffset(double) = 0;
- virtual void removedFromMediaSource() = 0;
+ virtual void addWebVTTCue(double start,
+ double end,
+ const WebString& id,
+ const WebString& content,
+ const WebString& settings) = 0;
};
} // namespace WebKit

Powered by Google App Engine
This is Rietveld 408576698