Create WebInbandTextTrack and WebInbandTextTrackClient

Source/WebKit/chromium/public/WebInbandTextTrack.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WebValidationMessageClient_h
-#define WebValidationMessageClient_h
-
-#include "WebTextDirection.h"
+#ifndef WebInbandTextTrack_h
+#define WebInbandTextTrack_h
 
 namespace WebKit {
 
 class WebString;
-struct WebRect;
+class WebInbandTextTrackClient;
 
-// Client interface to handle form validation message UI.
-class WebValidationMessageClient {
-public:
-    // Show a notification popup for the specified form vaidation messages
-    // besides the anchor rectangle. An implementation of this function should
-    // not hide the popup until hideValidationMessage call.
-    virtual void showValidationMessage(const WebRect& anchorInScreen, const WebString& mainText, const WebString& supplementalText, WebTextDirection hint) { }
+class WebInbandTextTrack {
+ public:

[abarth-chromium, 2013/04/30 18:36:16]

Please use Blink style (e.g., four-space indent)

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

+  enum Kind { KindSubtitles, KindCaptions, KindDescriptions, KindChapters, KindMetadata, KindNone };
+  enum Mode { ModeDisabled, ModeHidden, ModeShowing };

[abarth-chromium, 2013/04/30 18:36:16]

Please put the enum values on separate lines so that it's easier to review
changes to them.

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Done.

 
-    // Hide notifation popup for form validation messages.
-    virtual void hideValidationMessage() { }
+  virtual ~WebInbandTextTrack() {}
 
+  virtual void setClient(WebInbandTextTrackClient*) = 0;
+  virtual WebInbandTextTrackClient* client() = 0;
 
-protected:
-    virtual ~WebValidationMessageClient() { }
+  virtual void setMode(Mode) = 0;
+  virtual Mode mode() const = 0;
+
+  virtual Kind kind() const = 0;
+  virtual bool isClosedCaptions() const = 0;
+
+  virtual WebString label() const = 0;
+  virtual WebString language() const = 0;
+  virtual bool isDefault() const = 0;
+
+  virtual int textTrackIndex() const = 0;

[abarth-chromium, 2013/04/30 18:36:16]

Should the index be size_t ?

[Matthew Heaney (Chromium), 2013/05/01 04:38:24]

Good question.  Should we also rename this method, to inbandTextTrack ?

 };
 
 } // namespace WebKit
 
 #endif