Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396783004: Convert mojo::system::ChannelEndpointClient to use our new refcounting stuff (instead of base's). (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
vardhan
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert mojo::system::ChannelEndpointClient to use our new refcounting stuff (instead of base's). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e1116139ae6c2de89732bac8ad34c33c0a1514d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -285 lines) Patch
M mojo/edk/system/channel.h View 4 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/system/channel.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 5 chunks +8 lines, -9 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/channel_endpoint_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_endpoint_unittest.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M mojo/edk/system/channel_unittest.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M mojo/edk/system/core.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/endpoint_relayer.h View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.h View 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.cc View 2 chunks +14 lines, -16 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 5 chunks +15 lines, -13 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 8 chunks +22 lines, -21 lines 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 9 chunks +8 lines, -9 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 15 chunks +18 lines, -18 lines 0 comments Download
M mojo/edk/system/ref_counted.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 16 chunks +31 lines, -31 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-15 01:53:49 UTC) #1
viettrungluu
ping -- it's not as scary as it looks
5 years, 2 months ago (2015-10-15 18:08:06 UTC) #2
vardhan
lgtm
5 years, 2 months ago (2015-10-15 18:13:16 UTC) #3
viettrungluu
5 years, 2 months ago (2015-10-15 19:22:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e1116139ae6c2de89732bac8ad34c33c0a1514d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698