Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: mojo/edk/system/endpoint_relayer.h

Issue 1396783004: Convert mojo::system::ChannelEndpointClient to use our new refcounting stuff (instead of base's). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/dispatcher_unittest.cc ('k') | mojo/edk/system/endpoint_relayer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/endpoint_relayer.h
diff --git a/mojo/edk/system/endpoint_relayer.h b/mojo/edk/system/endpoint_relayer.h
index 5a61aa1549efa4d98f47f5b3a8efd9750fbd44be..f41de9680cd10739429eabebd04661539ca64de7 100644
--- a/mojo/edk/system/endpoint_relayer.h
+++ b/mojo/edk/system/endpoint_relayer.h
@@ -7,7 +7,6 @@
#include <memory>
-#include "base/memory/ref_counted.h"
#include "mojo/edk/system/channel_endpoint_client.h"
#include "mojo/edk/system/mutex.h"
#include "mojo/edk/system/ref_ptr.h"
@@ -62,7 +61,7 @@ class EndpointRelayer final : public ChannelEndpointClient {
MOJO_DISALLOW_COPY_AND_ASSIGN(Filter);
};
- EndpointRelayer();
+ // Note: Use |MakeRefCounted<EndpointRelayer>()|.
// Gets the other port number (i.e., 0 -> 1, 1 -> 0).
static unsigned GetPeerPort(unsigned port);
@@ -80,6 +79,9 @@ class EndpointRelayer final : public ChannelEndpointClient {
void OnDetachFromChannel(unsigned port) override;
private:
+ FRIEND_MAKE_REF_COUNTED(EndpointRelayer);
+
+ EndpointRelayer();
~EndpointRelayer() override;
Mutex mutex_;
« no previous file with comments | « mojo/edk/system/dispatcher_unittest.cc ('k') | mojo/edk/system/endpoint_relayer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698